Elioooon commented on code in PR #4017:
URL: https://github.com/apache/iggy/pull/4017#discussion_r3957780726
##########
core/shard/src/lib.rs:
##########
@@ -2530,6 +2530,10 @@ where
self.metrics.record_partition_removed();
confirmed_remove = true;
if let Some(partition) = removed {
+ // The tombstone fences writes before this point.
Rolling the
+ // detached counters out here prevents late shard
activity from
+ // underflowing or leaking into the topic and stream
totals.
+ partition.stats.zero_out_all();
Review Comment:
Addressed in a23d05d57 after merging master at a71ed7420 (#4046). Removed
the duplicate call and its comment; core/shard/src/lib.rs now has no diff from
master. The simulator counter assertions remain and pass with the upstream
cleanup (1 fault-injection test passed); metadata tests also pass (162).
Updated the PR body to attribute the rollback to #4046 and describe only the
remaining binding/test changes.
##########
foreign/python/src/client.rs:
##########
@@ -704,7 +681,8 @@ impl IggyClient {
/// Args:
/// stream: Stream identifier as `str | int`.
/// name: Topic name as `str`.
- /// partitions_count: Number of partitions as `int`.
+ /// partitions_count: Number of partitions as `int`, between 1 and 1000
Review Comment:
Addressed in a23d05d57: changed create_topic to “at most 1000” and
regenerated apache_iggy.pyi with stub_gen, then applied Ruff formatting.
Confirmed the shared admission helper accepts zero and ran
partitions_count_cap_denies_pre_consensus (1 passed). The positive-count
constraint remains on create_partitions/delete_partitions. Python Clippy, Ruff,
and the 3 binding unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
