gong commented on code in PR #8664:
URL: https://github.com/apache/inlong/pull/8664#discussion_r1307201077
##########
inlong-sort/sort-flink/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/relational/connection/JdbcConnectionPoolFactory.java:
##########
@@ -47,6 +47,8 @@ public HikariDataSource
createPooledDataSource(JdbcSourceConfig sourceConfig) {
config.addDataSourceProperty(SERVER_TIMEZONE_KEY,
sourceConfig.getServerTimeZone());
config.setDriverClassName(sourceConfig.getDriverClassName());
+ // note: the following properties should be optional (only applied to
MySQL)
+ config.addDataSourceProperty(SERVER_TIMEZONE_KEY,
sourceConfig.getServerTimeZone());
Review Comment:
`config.addDataSourceProperty(SERVER_TIMEZONE_KEY,
sourceConfig.getServerTimeZone());` is duplication code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
