gong commented on code in PR #8664:
URL: https://github.com/apache/inlong/pull/8664#discussion_r1307208277


##########
inlong-sort/sort-flink/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/source/meta/offset/OffsetDeserializerSerializer.java:
##########
@@ -84,7 +84,8 @@ default OffsetDeserializer createOffsetDeserializer() {
     default FinishedSnapshotSplitInfo deserialize(byte[] serialized) {
         try {
             final DataInputDeserializer in = new 
DataInputDeserializer(serialized);
-            TableId tableId = TableId.parse(in.readUTF());
+            boolean useCatalogBeforeSchema = in.readBoolean();
+            TableId tableId = TableId.parse(in.readUTF(), 
useCatalogBeforeSchema);

Review Comment:
   It should improve refer to 
https://github.com/ververica/flink-cdc-connectors/pull/2216 
   ```java
    default FinishedSnapshotSplitInfo deserialize(byte[] serialized) {
           try {
               final DataInputDeserializer in = new 
DataInputDeserializer(serialized);
               String tableIdStr = in.readUTF();
               String splitId = in.readUTF();
               Object[] splitStart = serializedStringToRow(in.readUTF());
               Object[] splitEnd = serializedStringToRow(in.readUTF());
               OffsetFactory offsetFactory = (OffsetFactory) 
serializedStringToObject(in.readUTF());
               Offset highWatermark = readOffsetPosition(in);
               boolean useCatalogBeforeSchema = true;
               if (in.available() > 0) {
                   useCatalogBeforeSchema = in.readBoolean();
               }
               TableId tableId = TableId.parse(tableIdStr, 
useCatalogBeforeSchema);
               in.releaseArrays();
   
               return new FinishedSnapshotSplitInfo(
                       tableId, splitId, splitStart, splitEnd, highWatermark, 
offsetFactory);
           } catch (IOException e) {
               throw new FlinkRuntimeException(e);
           }
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to