e-mhui commented on code in PR #8664:
URL: https://github.com/apache/inlong/pull/8664#discussion_r1322317712
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/postgres-cdc/src/main/java/org/apache/inlong/sort/cdc/postgres/source/config/PostgresSourceConfig.java:
##########
@@ -100,7 +101,7 @@ public RelationalTableFilters getTableFilters() {
@Override
public List<String> getMetricLabelList() {
- return Arrays.asList(AbstractSourceInfo.DATABASE_NAME_KEY,
+ return Arrays.asList(DATABASE_NAME_KEY,
Review Comment:
`cdc-base` module already has `DATABASE_NAME` constant, so you can import
it, not define it by yourself.
<img width="696" alt="image"
src="https://github.com/apache/inlong/assets/111486498/5492f9c2-5b83-459a-9ddb-32e39e74cdf2";>
you also refer Oracle CDC.
<img width="1040" alt="image"
src="https://github.com/apache/inlong/assets/111486498/feaa5bec-9a8e-4614-a262-2fe7cc0fb9f5";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
