yunqingmoswu commented on code in PR #8664:
URL: https://github.com/apache/inlong/pull/8664#discussion_r1324398449
##########
inlong-sort/sort-flink/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/source/assigner/HybridSplitAssigner.java:
##########
@@ -123,7 +123,8 @@ public Optional<SourceSplitBase> getNext() {
// assigning the stream split. Otherwise, records emitted from
stream split
// might be out-of-order in terms of same primary key with
snapshot splits.
isStreamSplitAssigned = true;
- return Optional.of(createStreamSplit());
+ StreamSplit streamSplit = createStreamSplit();
Review Comment:
This change is not necessary?
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/oracle-cdc/src/main/java/org/apache/inlong/sort/cdc/oracle/source/config/OracleSourceConfigFactory.java:
##########
@@ -108,10 +108,6 @@ public OracleSourceConfig create(int subtaskId) {
props.setProperty("database.port", String.valueOf(port));
}
- if (schemaList != null) {
Review Comment:
Why change the code of Oracle cdc?
##########
inlong-sort/sort-flink/cdc-base/src/main/java/org/apache/inlong/sort/cdc/base/source/reader/IncrementalSourceReader.java:
##########
@@ -237,7 +242,7 @@ private StreamSplit
discoverTableSchemasForStreamSplit(StreamSplit split) {
public void handleSourceEvents(SourceEvent sourceEvent) {
if (sourceEvent instanceof FinishedSnapshotSplitsAckEvent) {
FinishedSnapshotSplitsAckEvent ackEvent =
(FinishedSnapshotSplitsAckEvent) sourceEvent;
- LOG.debug(
+ LOG.info(
Review Comment:
Why change the log level, maybe it will cause a large amount of log output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
