tchughesiv commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1416063458
##########
controllers/platform/services.go:
##########
@@ -58,30 +55,32 @@ func (action *serviceAction) Handle(ctx context.Context,
platform *operatorapi.S
return nil, err
}
- if err := createDataIndexComponents(ctx, action.client, platform); err
!= nil {
- return nil, err
+ if platform.Spec.Services.DataIndex != nil {
Review Comment:
no, this flag only affects "prod" workflows. if it's a dev workflow, this
flag won't even be checked by the operator. when a user elects to set
`platform.spec.services.dataIndex.enabled` to `true` (which is the default),
they are saying they want "prod" workflows to use this data index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
