ricardozanini commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1419404469
##########
controllers/platform/services.go:
##########
@@ -58,30 +55,32 @@ func (action *serviceAction) Handle(ctx context.Context,
platform *operatorapi.S
return nil, err
}
- if err := createDataIndexComponents(ctx, action.client, platform); err
!= nil {
- return nil, err
+ if platform.Spec.Services.DataIndex != nil {
Review Comment:
I keep asking these to myself. Let's reevaluate the need for it. I remember
we discussed how to have the platform deploy the services and that's what we
came up with. If we enable deployment, we should also disable it. We must have
a response to irt or change the structure in a way that "disable" won't make
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
