jordigilh commented on code in PR #311:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1418285572


##########
controllers/profiles/common/app_properties.go:
##########
@@ -38,34 +43,313 @@ import (
 )
 
 const (
-       ConfigMapWorkflowPropsVolumeName = "workflow-properties"
-       kogitoServiceUrlProperty         = "kogito.service.url"
-       kogitoServiceUrlProtocol         = "http"
-       dataIndexServiceUrlProperty      = 
"mp.messaging.outgoing.kogito-processinstances-events.url"
-       kafkaSmallRyeHealthProperty      = 
"quarkus.smallrye-health.check.\"io.quarkus.kafka.client.health.KafkaHealthCheck\".enabled"
-       dataIndexServiceUrlProtocol      = "http"
-
-       DataIndexImageBase = "quay.io/kiegroup/kogito-data-index-"
-       DataIndexName      = "data-index-service"
-
-       PersistenceTypeEphemeral   = "ephemeral"
-       PersistenceTypePostgressql = "postgresql"
-
+       ConfigMapWorkflowPropsVolumeName        = "workflow-properties"
+       kogitoServiceUrlProperty                = "kogito.service.url"
+       kogitoServiceUrlProtocol                = "http"
+       dataIndexServiceUrlProperty             = 
"mp.messaging.outgoing.kogito-processinstances-events.url"
+       kafkaSmallRyeHealthProperty             = 
"quarkus.smallrye-health.check.\"io.quarkus.kafka.client.health.KafkaHealthCheck\".enabled"
+       dataIndexServiceUrlProtocol             = "http"
+       jobServiceURLProperty                   = 
"mp.messaging.outgoing.kogito-job-service-job-request-events.url"
+       jobServiceKafkaSinkInjectionHealthCheck = 
`quarkus.smallrye-health.check."org.kie.kogito.jobs.service.messaging.http.health.knative.KSinkInjectionHealthCheck".enabled`
+       jobServiceStatusChangeEventsProperty    = 
"kogito.jobs-service.http.job-status-change-events"
+       jobServiceStatusChangeEventsURL         = 
"mp.messaging.outgoing.kogito-job-service-job-status-events-http.url"
+       jobServiceURLProtocol                   = "http"
+       jobServiceDataSourceReactiveURLProperty = 
"quarkus.datasource.reactive.url"
+
+       imageNamePrefix                          = "quay.io/kiegroup/kogito"
+       DataIndexServiceName                     = "data-index-service"
+       DataIndexName                            = "data-index"
+       JobServiceName                           = "jobs-service"
+       PersistenceTypeEphemeral                 = "ephemeral"
+       PersistenceTypePostgressql               = "postgresql"
        microprofileServiceCatalogPropertyPrefix = 
"org.kie.kogito.addons.discovery."
        discoveryLikePropertyPattern             = 
"^\\${(kubernetes|knative|openshift):(.*)}$"
+
+       defaultDatabaseName   string = "sonataflow"
+       defaultPostgreSQLPort int    = 5432
+)
+
+var (
+       immutableApplicationProperties = "quarkus.http.port=" + 
DefaultHTTPWorkflowPortIntStr.String() + "\n" +
+               "quarkus.http.host=0.0.0.0\n" +
+               // We disable the Knative health checks to not block the dev 
pod to run if Knative objects are not available
+               // See: 
https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/eventing/consume-produce-events-with-knative-eventing.html#ref-knative-eventing-add-on-source-configuration
+               "org.kie.kogito.addons.knative.eventing.health-enabled=false\n" 
+
+               "quarkus.devservices.enabled=false\n" +
+               "quarkus.kogito.devservices.enabled=false\n"
+
+       discoveryLikePropertyExpr                    = 
regexp.MustCompile(discoveryLikePropertyPattern)
+       _                         AppPropertyHandler = &appPropertyHandler{}
 )
 
-var immutableApplicationProperties = "quarkus.http.port=" + 
DefaultHTTPWorkflowPortIntStr.String() + "\n" +
-       "quarkus.http.host=0.0.0.0\n" +
-       // We disable the Knative health checks to not block the dev pod to run 
if Knative objects are not available
-       // See: 
https://kiegroup.github.io/kogito-docs/serverlessworkflow/latest/eventing/consume-produce-events-with-knative-eventing.html#ref-knative-eventing-add-on-source-configuration
-       "org.kie.kogito.addons.knative.eventing.health-enabled=false\n" +
-       "quarkus.devservices.enabled=false\n" +
-       "quarkus.kogito.devservices.enabled=false\n"
+type PlatformService interface {

Review Comment:
   Moved inside the`platform` package.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to