tchughesiv commented on code in PR #311:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/311#discussion_r1416175525
##########
controllers/platform/services.go:
##########
@@ -58,30 +55,32 @@ func (action *serviceAction) Handle(ctx context.Context,
platform *operatorapi.S
return nil, err
}
- if err := createDataIndexComponents(ctx, action.client, platform); err
!= nil {
- return nil, err
+ if platform.Spec.Services.DataIndex != nil {
Review Comment:
@ricardozanini reviewing old notes i had on this, we discussed possibly
scaling down a service to 0 when `enabled` was set to `false`. currently,
however, the operator merely removes the
`mp.messaging.outgoing.kogito-processinstances-events.url` from new / changed
prod workflows.
i think that, during development, i realized scaling down to 0 would be
dangerous considering that connections from existing workflows would break.
If the end-goal is indeed to scale the service down when `enabled: false`,
we'd first need to revisit a separate enhancement request from @masayag around
restarting affected workflow pods when platform configs are changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
