tkobayas commented on PR #6292: URL: https://github.com/apache/incubator-kie-drools/pull/6292#issuecomment-2757175002
> provide a communication abstraction level between local vs remote engine invocation Remote engine (`DistributedRuntimeManager`) is not yet implemented, so this PR doesn't have a test for that, right? Some minor findings: - Similar to the above issue, filename `ModelLocalUriIdDeSerializerTest.java` doesn't match the class name `ModelLocalUriIdDeserializerTest`. It doesn't cause a compilation error, though. - `BaseEfestoInputExtenderModelLocalUriId.json`, `BaseEfestoInputModelLocalUriId.json`, `BaseInputMessage.json`, `NotExistingEfestoInputModelLocalUriId.json` under `NotExistingEfestoInputModelLocalUriId.json` don't seem to be used. Am I overlooking something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
