gitgabrio commented on code in PR #6292:
URL:
https://github.com/apache/incubator-kie-drools/pull/6292#discussion_r2018191974
##########
efesto/efesto-core/efesto-common-api/src/main/java/org/kie/efesto/common/api/model/EfestoCompilationContext.java:
##########
@@ -37,7 +35,7 @@ public interface EfestoCompilationContext<T extends
EfestoListener> extends Efes
Map<String, byte[]> compileClasses(Map<String, String> sourcesMap);
void loadClasses(Map<String, byte[]> compiledClassesMap);
- ServiceLoader<KieCompilerService> getKieCompilerServiceLoader();
+ ServiceLoader getKieCompilerServiceLoader();
Review Comment:
`EfestoCompilationContext` and `EfestoRuntimeContext` has been moved to
`efesto-common-api`, to be always visible (i.e. it could be needed for PMML
invocation from DMN), `KieCompilerService` remains in
`efesto-compilation-manager-api`.
Moving `KieCompilerService` to `efesto-common-api` would require to move a
lot of other classes, though 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
