yesamer commented on code in PR #6292:
URL:
https://github.com/apache/incubator-kie-drools/pull/6292#discussion_r2018546175
##########
efesto/efesto-core/efesto-runtime-manager/efesto-runtime-manager-api/src/main/java/org/kie/efesto/runtimemanager/api/utils/SPIUtils.java:
##########
@@ -18,21 +18,18 @@
*/
package org.kie.efesto.runtimemanager.api.utils;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Optional;
-import java.util.ServiceLoader;
-import java.util.Set;
-
import org.kie.efesto.runtimemanager.api.exceptions.KieRuntimeServiceException;
import org.kie.efesto.runtimemanager.api.model.EfestoInput;
-import org.kie.efesto.runtimemanager.api.model.EfestoRuntimeContext;
-import org.kie.efesto.runtimemanager.api.service.KieRuntimeService;
-import org.kie.efesto.runtimemanager.api.service.RuntimeManager;
+import org.kie.efesto.runtimemanager.api.model.EfestoLocalRuntimeContext;
+import org.kie.efesto.common.api.model.EfestoRuntimeContext;
+import org.kie.efesto.runtimemanager.api.service.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.util.*;
Review Comment:
Am I wrong, or should we avoid to import a package in that way?
##########
efesto/efesto-core/efesto-common-api/src/main/java/org/kie/efesto/common/api/utils/MemoryFileUtils.java:
##########
@@ -131,8 +131,8 @@ static File getFileFromResource(URL retrieved) throws
IOException {
static File getFileFromJar(URL retrieved) throws URISyntaxException,
IOException {
logger.debug("getFileFromJar {}", retrieved);
String fileName = retrieved.getFile();
- if (fileName.contains("/")) {
- fileName = fileName.substring(fileName.lastIndexOf('/'));
+ if (fileName.contains("!/")) {
+ fileName = fileName.substring((fileName.lastIndexOf("!/") + 1));
Review Comment:
@gitgabrio Is this change tested somewhere? It could be useful to have a
unit test for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
