yesamer commented on code in PR #6292:
URL:
https://github.com/apache/incubator-kie-drools/pull/6292#discussion_r2016172330
##########
efesto/efesto-core/efesto-common-api/src/main/java/org/kie/efesto/common/api/io/MemoryFile.java:
##########
@@ -43,7 +43,8 @@ public class MemoryFile extends File implements Serializable {
private byte[] content;
public MemoryFile(Path filePath) throws IOException {
- super(filePath.getFileName().toString());
+ //super(filePath.getFileName().toString());
+ super(filePath.toString());
Review Comment:
@gitgabrio Is this intended? If yes, please remove the above commented line.
##########
efesto/efesto-core/efesto-common-api/src/main/java/org/kie/efesto/common/api/model/EfestoCompilationContext.java:
##########
@@ -37,7 +35,7 @@ public interface EfestoCompilationContext<T extends
EfestoListener> extends Efes
Map<String, byte[]> compileClasses(Map<String, String> sourcesMap);
void loadClasses(Map<String, byte[]> compiledClassesMap);
- ServiceLoader<KieCompilerService> getKieCompilerServiceLoader();
+ ServiceLoader getKieCompilerServiceLoader();
Review Comment:
@gitgabrio Can you please explain why you omitted the generic type for that
`ServiceLoader`?
##########
kie-pmml-trusty/kie-pmml-api/pom.xml:
##########
@@ -53,6 +53,11 @@
<artifactId>efesto-runtime-manager-api</artifactId>
</dependency>
<!-- EXTERNAL -->
+ <dependency>
+ <groupId>jakarta.xml.bind</groupId>
+ <artifactId>jakarta.xml.bind-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
@gitgabrio Can you explain why this is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
