nrknithin commented on PR #6903: URL: https://github.com/apache/incubator-kie/pull/6903#issuecomment-5528083289
> Hi @nrknithin @tkobayas @yesamer @jstastny-cz @martinweiler @pefernan I think this PR goes, somehow, against the bom-splitting approach and design. The idea behind it was to remove the binding between quarkus and springboot frameworks/dependencies, but we are falling back to the old habit of mixing everything in one single place, and this will recreate the problem we invest so much effort to fix. > > What I see in this PR is that all the dependency changes required for ->quarkus upgrade<- are written in the kie-parent, hence affecting also the springboot framework. The consequence of that goes outside our own code, because springboot users will find their dependency tree modified - and potentially broken - by this change. Probably some changes are minimal, but I see some about infinispan and hibernate that could have some impact. The fact that the build is succeeding, unfortunately, may reflect lack of coverage. Thanks @gitgabrio — you're right, and I've changed the PR because of it: kie-parent's inherited management does outrank the BOMs imported below it, so a bump there reaches Spring Boot. Six of the eight packages you'd care about now resolve exactly what they do on main. - Unchanged for Spring Boot: grpc 1.76.0, in-memory-messaging 4.28.0, guava 33.4.8-jre, mutiny 2.9.5, hibernate 7.1.18.Final, postgresql 42.7.12 — Quarkus gets 1.81.0 / 4.33.0 / 33.5.0-jre / 3.1.1 / 7.2.19.Final / 42.7.13 via a property override in kogito-quarkus-bom (and kie-quarkus-build-parent for the drools-quarkus tree). - Still changed: infinispan 16.0.13 and protostream 6.0.7. These can't be split — drools-reliability sits under drools-build-parent, neither framework BOM, and declares them with no version; the shared addons are compiled once against ProtoStream 6. - One real defect found and fixed: the Spring Boot classpath was mixed (protostream-types 5.0.13 under protostream 6.0.7, counter-api 15.2.6 under hotrod 16.0.13). Now coherent via an infinispan-bom import in kogito-springboot/bom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
