nrknithin commented on code in PR #6903:
URL: https://github.com/apache/incubator-kie/pull/6903#discussion_r3933479344
##########
kie-parent/pom.xml:
##########
@@ -148,13 +148,13 @@
<version.io.netty>4.1.136.Final</version.io.netty>
<version.io.opentelemetry>1.0.0-alpha</version.io.opentelemetry>
<version.io.rest-assured>5.5.6</version.io.rest-assured>
- <version.io.smallrye-config>3.13.4</version.io.smallrye-config>
- <version.io.smallrye-health>4.2.0</version.io.smallrye-health>
- <version.io.smallrye-open-api>4.0.12</version.io.smallrye-open-api>
- <version.io.smallrye.config.core>3.13.4</version.io.smallrye.config.core>
- <version.io.smallrye.jandex>3.4.0</version.io.smallrye.jandex>
+ <version.io.smallrye-config>3.16.0</version.io.smallrye-config>
+ <version.io.smallrye-health>4.3.0</version.io.smallrye-health>
+ <version.io.smallrye-open-api>4.2.4</version.io.smallrye-open-api>
+ <version.io.smallrye.config.core>3.16.0</version.io.smallrye.config.core>
+ <version.io.smallrye.jandex>3.5.3</version.io.smallrye.jandex>
<version.io.smallrye.mutiny>2.9.5</version.io.smallrye.mutiny>
- <version.io.smallrye.openapi.core>4.0.12</version.io.smallrye.openapi.core>
+ <version.io.smallrye.openapi.core>4.2.4</version.io.smallrye.openapi.core>
Review Comment:
@gitgabrio
- What changed: smallrye-config / smallrye-open-api / jandex in kie-parent
moved to the quarkus-bom 3.33.3.1 versions (3.16.0 / 4.2.4 / 3.5.3).
- Why in kie-parent: it's an ancestor of kogito-quarkus-bom, and inherited
dependencyManagement beats an imported BOM — so kie-parent's version is what
every Quarkus module actually gets; the quarkus-bom import can't override it
(verified: forcing kie-parent to 3.13.4 makes jobs-service-common resolve
3.13.4).
- Why not leave the old values: Quarkus 3.33 then fails at JVM start with
NoClassDefFoundError: io/smallrye/config/Config (0 tests run) — the class isn't
in 3.13.4. And these values have always tracked the Quarkus platform (3.20 →
3.11.4, 3.27 → 3.13.4, brought into kie-parent unchanged by #6633); the core
modules using them needed no code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
