nrknithin commented on PR #6903: URL: https://github.com/apache/incubator-kie/pull/6903#issuecomment-5567822045
> Thanks @nrknithin ! @yesamer @pefernan : could you please review again ? My left doubt is about infinispan: the version has been changed on kie-parent and then a modification become needed on springboot bom. I would not expect that for pure-quarkus upgrade... @gitgabrio Infinispan/ProtoStream are shared. The same code runs on both Spring Boot and Quarkus, and the ProtoStream 6 upgrade also required changes to the shared marshalling code. The important part is that Infinispan 16 requires ProtoStream 6, so they need to move together. Also, the Infinispan version property drives the server image used by the ITs on both sides, so keeping it framework-specific would require splitting that as well. The Spring Boot BOM change is only to avoid mixing Infinispan 15 and 16 in the same classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
