jstastny-cz commented on code in PR #6903:
URL: https://github.com/apache/incubator-kie/pull/6903#discussion_r3948226379
##########
drools-compiler/src/main/java/org/drools/compiler/builder/impl/processors/ReteCompiler.java:
##########
@@ -22,10 +22,10 @@
import java.util.Collection;
import org.drools.base.RuleBase;
-import org.drools.compiler.builder.impl.AssetFilter;
-import org.drools.compiler.compiler.PackageRegistry;
import org.drools.base.definitions.InternalKnowledgePackage;
import org.drools.base.definitions.rule.impl.RuleImpl;
+import org.drools.compiler.builder.impl.AssetFilter;
Review Comment:
I don't think these changes should be submitted as part of this PR. Also
other files are affected.
##########
drools-quarkus-extension/drools-quarkus-util-deployment/src/main/java/org/drools/quarkus/util/deployment/QuarkusAppPaths.java:
##########
@@ -52,7 +51,8 @@ private enum PathType {
}
protected QuarkusAppPaths(List<Path> projectPaths, Collection<Path>
classesPaths, boolean isJar) {
- super(projectPaths, classesPaths, isJar, AppPaths.BT,
JarResultBuildStep.MAIN, false);
+ // "main" = quarkus-app output subdir (formerly
JarResultBuildStep.MAIN, removed in Quarkus 3.33)
+ super(projectPaths, classesPaths, isJar, AppPaths.BT, "main", false);
Review Comment:
Wouldn't AppPaths.MAIN_DIR be better?
##########
drools-reliability/drools-reliability-tests/src/test/java/org/drools/reliability/test/ReliabilityTestBasics.java:
##########
@@ -142,8 +143,8 @@ static Stream<PersistedSessionOption.PersistenceStrategy>
strategyProviderFull()
public void setUp() {
if (((TestableStorageManager)
StorageManagerFactory.get().getStorageManager()).isRemote()) {
LOG.info("Starting InfinispanContainer");
- container = new InfinispanContainer()
- .withFileSystemBind("infinispan-remote-config",
"/user-config")
+ container = new
InfinispanContainer(InfinispanContainer.IMAGE_BASENAME + ":" +
Version.getMajorMinor());
Review Comment:
Doesn't the need for this version specification indicate there's a
misconfiguration of the image being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
