ccoulombe commented on code in PR #21093: URL: https://github.com/apache/incubator-mxnet/pull/21093#discussion_r922251465
########## cmake/ChooseBlas.cmake: ########## @@ -33,7 +34,14 @@ if(USE_BLAS MATCHES "MKL" OR USE_BLAS MATCHES "mkl" OR NOT DEFINED USE_BLAS) endif() endif() -if(BLAS STREQUAL "Atlas" OR BLAS STREQUAL "atlas") +if(BLAS STREQUAL "FlexiBLAS" OR BLAS STREQUAL "flexiblas") + find_package(BLAS REQUIRED) Review Comment: Yes, as I do set it at CLI anyway. It could be done for the others as well. But I feel it is the same as setting the preferred BLAS with `BLAS=FlexiBLAS`. Unless you have in mind to refactor a bit so that `find_package` is by itself unless one set a preferred BLAS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
