ccoulombe commented on code in PR #21093: URL: https://github.com/apache/incubator-mxnet/pull/21093#discussion_r1008368842
########## cmake/ChooseBlas.cmake: ########## @@ -33,7 +34,14 @@ if(USE_BLAS MATCHES "MKL" OR USE_BLAS MATCHES "mkl" OR NOT DEFINED USE_BLAS) endif() endif() -if(BLAS STREQUAL "Atlas" OR BLAS STREQUAL "atlas") +if(BLAS STREQUAL "FlexiBLAS" OR BLAS STREQUAL "flexiblas") + find_package(BLAS REQUIRED) Review Comment: I think it is best to raise the minimum cmake version especially since there's a lot of nice to have and improvement in recent version. My opinion is : _live in the present and look in front, not behind_ in terms of versions. How would that break for users? (I mean except having to update their cmake version.) Have two requirements in different places could be surprising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
