leezu commented on code in PR #21093: URL: https://github.com/apache/incubator-mxnet/pull/21093#discussion_r930531912
########## cmake/ChooseBlas.cmake: ########## @@ -33,7 +34,14 @@ if(USE_BLAS MATCHES "MKL" OR USE_BLAS MATCHES "mkl" OR NOT DEFINED USE_BLAS) endif() endif() -if(BLAS STREQUAL "Atlas" OR BLAS STREQUAL "atlas") +if(BLAS STREQUAL "FlexiBLAS" OR BLAS STREQUAL "flexiblas") + find_package(BLAS REQUIRED) Review Comment: For the other BLAS besides MKL this ChooseBlas.cmake does not rely on the [upstream find_package(BLAS)](https://cmake.org/cmake/help/latest/module/FindBLAS.html). My only concern is that with your PR, users can specify BLAS=FlexiBLAS, but your find_package(BLAS) will find any BLAS that may or may not be FlexiBLAS. That's why it will be helpful for you to force BLA_VENDOR=FlexiBLAS inside this if clause. So, specifically I'm suggesting adding a `set(BLA_VENDOR FlexiBLAS)` before the current line but still inside the if clause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
