leezu commented on code in PR #21093: URL: https://github.com/apache/incubator-mxnet/pull/21093#discussion_r973760719
########## cmake/ChooseBlas.cmake: ########## @@ -33,7 +34,14 @@ if(USE_BLAS MATCHES "MKL" OR USE_BLAS MATCHES "mkl" OR NOT DEFINED USE_BLAS) endif() endif() -if(BLAS STREQUAL "Atlas" OR BLAS STREQUAL "atlas") +if(BLAS STREQUAL "FlexiBLAS" OR BLAS STREQUAL "flexiblas") + find_package(BLAS REQUIRED) Review Comment: Thank you! How about keeping the CMakeLists.txt cmake_minimum_required as is and adding `cmake_minimum_required(VERSION 3.19)` before `set(BLA_VENDOR FlexiBLAS)` inside the if clause? That would avoid unnecessarily breaking users on Ubuntu 20.04 LTS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
