samskalicky commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384301289
##########
File path: example/extensions/lib_subgraph/subgraph_lib.cc
##########
@@ -205,7 +205,7 @@ MXReturnValue mySupportedOps(std::string json,
}
//check if op dtype is float
- if(dtype == kFloat32) {
+ if((dtype == kFloat32 && options.count("reqFloat") > 0) ||
options.count("reqFloat") == 0) {
Review comment:
changed the comment to clarify:
```
//check if op dtype is float, and if option was specified to require float
types
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
