samskalicky commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384302001
##########
File path: example/extensions/lib_subgraph/subgraph_lib.cc
##########
@@ -177,7 +177,7 @@ REGISTER_OP(_custom_subgraph_op)
const std::vector<std::string> op_names({"exp","log"});
MXReturnValue mySupportedOps(std::string json,
- std::vector<bool> ids,
+ std::vector<bool>& ids,
Review comment:
In the doc it says
> The 2nd argument is an array of booleans, one for each operator in the
model. When traversing the graph, operators to be partitioned into subgraphs
are identified and an entry is set to `true` for the index in the `ids` array
corresponding to the node ID.
Is that sufficient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
