rondogency commented on a change in pull request #17623: Dynamic subgraph 
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r388632121
 
 

 ##########
 File path: tests/python/unittest/test_extensions.py
 ##########
 @@ -167,3 +167,17 @@ def test_subgraph():
     out4 = sym_block(mx.nd.ones((3,2)),mx.nd.ones((3,2)))
     # check that result matches one executed by MXNet
     assert_almost_equal(out[0].asnumpy(), out4[0].asnumpy(), rtol=1e-3, 
atol=1e-3)
+
+    # Gluon Hybridize partitioning with shapes/types
+    sym_block2 = nn.SymbolBlock(sym, [a,b])
+    sym_block2.initialize()
+    a_data = mx.nd.ones((3,2))
+    b_data = mx.nd.ones((3,2))
 
 Review comment:
   I just realized you didn't do the randomized inputs like the custom op test, 
I am thinking if it might be risky

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to