rondogency commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r388633030
##########
File path: include/mxnet/lib_api.h
##########
@@ -407,6 +412,8 @@ class OpResource {
*/
/*! \brief Macro to help passing serialized subgraph through attribute dict */
#define SUBGRAPH_SYM_JSON "subgraph_sym_json"
+#define MX_DTYPE "__dtype__"
+#define MX_SHAPE "__shape__"
Review comment:
should we call it MX_STR_DTYPE? this name is too general and may cause some
naming conflict
Also I seriously consider we should namespace all the primitives in
lib_api.h, but it requires more work and we don't need to prioritize it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
