samskalicky commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r388636221
##########
File path: include/mxnet/lib_api.h
##########
@@ -234,10 +234,15 @@ enum MXReturnValue {
*/
struct MXTensor {
MXTensor() : data_ptr(nullptr), dtype(kUNSET), verID(0) {}
-
+ MXTensor(const MXTensor& oth) : data_ptr(oth.data_ptr), shape(oth.shape),
+ dtype(oth.dtype), verID(oth.verID), ctx(oth.ctx) {
+ setDLTensor();
Review comment:
In this case, its the copy constructor. So we're constructing an MXTensor
from another one, and we need to setup the DLTensor for the new one that we're
constructing. This is used in std::map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services