rondogency commented on a change in pull request #17623: Dynamic subgraph
compile support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r388630569
##########
File path: python/mxnet/symbol/symbol.py
##########
@@ -1475,13 +1482,19 @@ def optimize_for(self, backend, args=None, ctx=None,
**kwargs):
out = SymbolHandle()
assert isinstance(backend, str)
- if args is None:
+ if args is None or len(args) == 0:
args = []
args_handle = c_array(NDArrayHandle, [])
else:
- listed_arguments = self.list_arguments()
- args_handle, args = self._get_ndarray_inputs('args', args,
listed_arguments, False)
+ args_handle, args = self._get_ndarray_inputs('args', args,
+
self.list_arguments(), False)
+ if aux is None or len(aux) == 0:
+ aux = []
Review comment:
do we need this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
