yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r208732806
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala
##########
@@ -136,11 +142,29 @@ class DataBatch(val data: IndexedSeq[NDArray],
val pad: Int,
// the key for the bucket that should be used for this batch,
// for bucketing io only
- val bucketKey: AnyRef = null,
+ val bucketKey: AnyRef,
// use ListMap to indicate the order of data/label loading
// (must match the order of input data/label)
- private val providedData: ListMap[String, Shape] = null,
- private val providedLabel: ListMap[String, Shape] = null) {
+ private val providedData: ListMap[String, Shape],
+ private val providedLabel: ListMap[String, Shape],
+ val dataDType: DType,
+ val labelDType: DType,
+ val dataLayout: String,
+ val labelLayout: String) {
Review comment:
I'm wondering whether we can pack them all into dataDesc and labelDesc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
