yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210060938
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/IO.scala
##########
@@ -332,8 +379,9 @@ abstract class DataPack() extends Iterable[DataBatch] {
// Named data desc description contains name, shape, type and other extended
attributes.
case class DataDesc(name: String, shape: Shape,
- dtype: DType = Base.MX_REAL_TYPE, layout: String = "NCHW")
{
- require(shape.length == layout.length, ("number of dimensions in shape :%d
with" +
+ dtype: DType = Base.MX_REAL_TYPE, layout: String =
Layout.UNDEFINED) {
Review comment:
can we add a constructor to allow java users easily create DataDesc without
specifying `dtype` and `layout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
