yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r209099209
##########
File path:
scala-package/core/src/main/scala/org/apache/mxnet/io/NDArrayIter.scala
##########
@@ -101,10 +115,16 @@ class NDArrayIter(data: IndexedSeq[(String, NDArray)],
private var cursor = -dataBatchSize
private val (_provideData: ListMap[String, Shape],
- _provideLabel: ListMap[String, Shape]) = {
+ _provideLabel: ListMap[String, Shape],
Review comment:
My major point was no need to fetch the data twice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
