yzhliu commented on a change in pull request #11844: [MXNET-689] add DataDesc
type for the Scala Package
URL: https://github.com/apache/incubator-mxnet/pull/11844#discussion_r210087276
##########
File path:
scala-package/examples/src/main/scala/org/apache/mxnetexamples/rnn/BucketIo.scala
##########
@@ -94,8 +96,22 @@ object BucketIo {
class BucketSentenceIter(
path: String, vocab: Map[String, Int], var buckets: IndexedSeq[Int],
_batchSize: Int, private val initStates: IndexedSeq[(String, (Int,
Int))],
- seperateChar: String = " <eos> ", text2Id: Text2Id = defaultText2Id,
- readContent: ReadContent = defaultReadContent) extends DataIter {
+ seperateChar: String, text2Id: Text2Id,
+ readContent: ReadContent,
+ dataLayout: String,
+ labelLayout: String,
+ dataDType : DType,
+ labelDType: DType) extends DataIter {
+
+ // scalastyle:off
+ def this(path: String, vocab: Map[String, Int], buckets: IndexedSeq[Int],
+ _batchSize: Int, initStates: IndexedSeq[(String, (Int, Int))],
+ seperateChar: String = " <eos> ", text2Id: Text2Id = defaultText2Id,
+ readContent: ReadContent = defaultReadContent) {
Review comment:
code-style: add indent for args
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
