apeforest commented on a change in pull request #14836: Refactor AGInfo and
Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305028495
##########
File path: src/nnvm/gradient.cc
##########
@@ -190,7 +190,8 @@ Graph Gradient(Graph src) {
if (grad_fun_map.contains(ptr->op())) {
input_grads = grad_fun_map[ptr->op()](fwd_node, out_agg_grads);
CHECK_EQ((*rit)->inputs.size(), input_grads.size())
- << "Gradient function not returning enough gradient";
+ << "Gradient function not returning enough gradient, there should
be as many gradients"
Review comment:
Nice comment!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
