apeforest commented on a change in pull request #14836: Refactor AGInfo and
Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305028066
##########
File path: src/io/iter_sparse_prefetcher.h
##########
@@ -126,15 +126,15 @@ class SparsePrefetcherIter : public PrefetcherIter {
virtual bool Next(void) {
return PrefetcherIter::Next();
}
- virtual const DataBatch &Value(void) const {
Review comment:
I think both styles are fine:
https://google.github.io/styleguide/cppguide.html#Pointer_and_Reference_Expressions
No need to change this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
