apeforest commented on a change in pull request #14836: Refactor AGInfo and
Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r305030002
##########
File path: include/mxnet/imperative.h
##########
@@ -160,15 +165,37 @@ class Imperative {
private:
friend class NDArray;
- /*! \brief make constructor protected. */
+ /*! Create a forward graph
+ * @param output_nodes graph node vector to add nodes to
+ * @param outputs source ndarrays
+ * @return vector of nodes
+ */
+ static std::vector<nnvm::NodeEntry> CreateForwardGraph(const
std::vector<NDArray*>& outputs);
Review comment:
This function is very confusing. It does not really create a graph
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
