apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310780707
##########
File path: include/mxnet/c_api.h
##########
@@ -55,7 +55,9 @@ extern "C" {
#endif
/*! \brief manually define unsigned int */
-typedef unsigned int mx_uint;
+typedef uint32_t mx_uint;
+/*! \brief manually define 64-bit int */
+typedef int64_t mx_int64;
Review comment:
@larroy I also feel this typedef with the rest mx_* typedef should go away
in this file. @access2rohit has agreed to do it in his next PR for consistency
purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
