apeforest commented on a change in pull request #15593: Large Index Support for
Slice
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782296
##########
File path: src/c_api/c_api_common.h
##########
@@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry {
/*! \brief result holder for returning shape pointer */
std::vector<const mx_uint*> arg_shape_data, out_shape_data, aux_shape_data;
/*! \brief result holder for returning shape pointer */
- std::vector<const int*> arg_shape_data_ex, out_shape_data_ex,
aux_shape_data_ex;
+ std::vector<const dtype*> arg_shape_data_ex, out_shape_data_ex,
aux_shape_data_ex;
+ //std::vector<const int64_t*> arg_shape_data_ex_int64,
out_shape_data_ex_int64,
Review comment:
please remove commented code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
