andrzej-kaczmarek commented on code in PR #2884:
URL: https://github.com/apache/mynewt-core/pull/2884#discussion_r980894944
##########
hw/mcu/dialog/da1469x/include/mcu/da1469x_hal.h:
##########
@@ -85,6 +85,8 @@ struct qspi_flash_config {
extern const struct qspi_flash_config rdids[];
extern const int qspi_flash_config_array_size;
+extern const struct qspi_flash_config *rdid_detected;
Review Comment:
I'd prefer to have getter for this so apps don't rely on variable name
##########
hw/mcu/dialog/da1469x/src/hal_flash.c:
##########
@@ -430,6 +430,9 @@ qspi_read_rdid(const struct hal_flash *dev)
int i;
uint32_t result;
+ da1469x_qspi_mode_manual(dev);
+ da1469x_qspi_wait_busy(dev);
Review Comment:
why not just add wait_busy to init? this way auto mode is disabled and then
re-enabled by the same function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
