andrzej-kaczmarek commented on code in PR #2884:
URL: https://github.com/apache/mynewt-core/pull/2884#discussion_r981663328
##########
hw/mcu/dialog/da1469x/src/hal_flash.c:
##########
@@ -430,6 +430,9 @@ qspi_read_rdid(const struct hal_flash *dev)
int i;
uint32_t result;
+ da1469x_qspi_mode_manual(dev);
+ da1469x_qspi_wait_busy(dev);
Review Comment:
`qspi_read_rdid` is just a helper, it does not need to handle controller
mode - this is done by caller which is `da1469x_hff_mcu_custom_init` and does
everything just as two other mentioned functions so basically it makes sense to
also add wait busy to init func. it's just like a critical section - you don't
expect helpers to enter critical section, they can just assume they are called
inside a critical section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
