andrzej-kaczmarek commented on code in PR #2884:
URL: https://github.com/apache/mynewt-core/pull/2884#discussion_r981614827
##########
hw/mcu/dialog/da1469x/src/hal_flash.c:
##########
@@ -430,6 +430,9 @@ qspi_read_rdid(const struct hal_flash *dev)
int i;
uint32_t result;
+ da1469x_qspi_mode_manual(dev);
+ da1469x_qspi_wait_busy(dev);
Review Comment:
`qspi_read_rdid` is static here so not sure how you call it in other places,
but if you somehow do then fixed version has rather unexpected side-effect of
switching qspi controller to manual mode. in `hal_flash` it's used as a helper
and caller takes care of switching qspi between manual and auto mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
