agross-korg commented on code in PR #2884:
URL: https://github.com/apache/mynewt-core/pull/2884#discussion_r981619657
##########
hw/mcu/dialog/da1469x/src/hal_flash.c:
##########
@@ -430,6 +430,9 @@ qspi_read_rdid(const struct hal_flash *dev)
int i;
uint32_t result;
+ da1469x_qspi_mode_manual(dev);
+ da1469x_qspi_wait_busy(dev);
Review Comment:
It was now, but I found this issue when I was experimenting with having
access to the rdid function. Personally, I'd rather functions that do
something specific do all of the things that need to be done to be successful.
There are other functions where we do this set manual mode, wait for busy.
This makes this consistent with those other functions. Examples:
da1469x_qspi_write and da1469x_qspi_erase_sector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
