[ 
https://issues.apache.org/jira/browse/NIFI-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093248#comment-15093248
 ] 

Mans Singh commented on NIFI-1325:
----------------------------------

Hi Aldrin:
Thanks for your recommendations.  I am making the changes that James had 
mentioned locally.  I am new to git, so can you please let me know how I can 
merge your changes with those and update the patch ?  If there any other 
suggestion, please let me know.
Thanks again for your help/advice.
Mans 

    On Monday, January 11, 2016 7:28 PM, Aldrin Piri (JIRA) <[email protected]> 
wrote:
 

 
    [ 
https://issues.apache.org/jira/browse/NIFI-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093223#comment-15093223
 ] 

Aldrin Piri commented on NIFI-1325:
-----------------------------------

Mans,

A couple of quick points that I ran into from a more NiFi-centric point of 
view.  Most of these are very minor and I made the relevant changes in a branch 
at my own fork, the commit of which can be seen here:  
https://github.com/apiri/incubator-nifi/commit/dc166f605886e68280d6b25c8ff371595509c3cf

Ultimately, this is just some minor whitespace issues causing our contrib-check 
to fail (empty line with spaces and usage of tabs instead of spaces), 
preferring to use the NiFi logger made available to the components by the 
framework, dialing down log level, and adjusting some typos.  If you have a few 
spare moments, let me know if these things seem agreeable with you.  When we 
get your efforts into a form ready to be committed, I can combine these fixes 
with what you have or you can feel free to incorporate them into what you are 
currently working on.

Thanks!




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)




> Enhance AWS S3 fetch to access bucket across accounts
> -----------------------------------------------------
>
>                 Key: NIFI-1325
>                 URL: https://issues.apache.org/jira/browse/NIFI-1325
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.4.1
>         Environment: All
>            Reporter: Mans Singh
>            Assignee: Tony Kurc
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 0.4.1
>
>         Attachments: nifi-1325.patch.zip, nifi-1325.patch.zip
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The AWS S3 Fetch Object component does not allow access to bucket across 
> accounts. AWS  S3 Fetch Object with can be enhanced to provide this 
> functionality by using assume role session/credentials 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to