[ 
https://issues.apache.org/jira/browse/NIFI-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093194#comment-15093194
 ] 

Aldrin Piri commented on NIFI-1325:
-----------------------------------

[~jameswing] as Joe mentioned these changes would be adjusted when we get the 
opportunity to do so with 1.0.  Also not a big fan of the abused inheritance 
but seemed like the only workable solution given the constraints currently 
imposed.  Did you have any ideas for improvements that maintain the contract 
previously established?  Can't think of a cleaner way with the above 
considerations but admittedly feeling like I have tunnel vision in 
consideration of this issue.

Your insights into some of the specifics of the AWS API are great.  I have some 
minor experience with the API, but nowhere near the familiarity to get to 
points like that.  Doing some scanning over the related docs, those certainly 
seem like desirable and worthwhile adjustments.

Agree concerning the naming of Assume Role and the incorporation of tags.

Concerning naming conventions, it is true that the "Impls" are fairly light in 
the codebase but we also do not have any hard and fast standards on that front. 
 Most of the ControllerService interfaces are typically named some base name 
with the base implementation being Standard<base name>.

Thanks for bringing your perspective and thoughts to this issue!  Certainly 
helps us get things right and address the wider needs that are out there.

> Enhance AWS S3 fetch to access bucket across accounts
> -----------------------------------------------------
>
>                 Key: NIFI-1325
>                 URL: https://issues.apache.org/jira/browse/NIFI-1325
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.4.1
>         Environment: All
>            Reporter: Mans Singh
>            Assignee: Tony Kurc
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 0.4.1
>
>         Attachments: nifi-1325.patch.zip, nifi-1325.patch.zip
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The AWS S3 Fetch Object component does not allow access to bucket across 
> accounts. AWS  S3 Fetch Object with can be enhanced to provide this 
> functionality by using assume role session/credentials 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to