[ 
https://issues.apache.org/jira/browse/NIFI-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095247#comment-15095247
 ] 

Aldrin Piri commented on NIFI-1325:
-----------------------------------

[~mans2singh] [~jameswing]

Mans, everything looks great.  Made some minor stylistic changes and migrated 
the tests you had separate classes for into the test classes already a part of 
the codebase (e.g. UnitTestDeleteS3Object -> TestDeleteS3Object).

The totality of these changes are at: 
https://github.com/apiri/incubator-nifi/commit/a0ee31f45fbb5e9d83dc45a7212abc33682932d1.
  Let me know if that looks agreeable with you and I will take the remaining 
steps to get this merged into master.

James, I applied your patch over top of Mans' as instructed and that looks good 
as well.

Thank you both for your efforts and perspectives on making this work possible 
in a usable manner!

> Enhance AWS S3 fetch to access bucket across accounts
> -----------------------------------------------------
>
>                 Key: NIFI-1325
>                 URL: https://issues.apache.org/jira/browse/NIFI-1325
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.4.1
>         Environment: All
>            Reporter: Mans Singh
>            Assignee: Tony Kurc
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 0.4.1
>
>         Attachments: JW_Patch_On_MS_0005.zip, nifi-1325.patch.zip, 
> nifi-1325.patch.zip, nifi-1325.patch.zip
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The AWS S3 Fetch Object component does not allow access to bucket across 
> accounts. AWS  S3 Fetch Object with can be enhanced to provide this 
> functionality by using assume role session/credentials 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to