[
https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170217#comment-15170217
]
ASF GitHub Bot commented on NIFI-1180:
--------------------------------------
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/246#issuecomment-189543249
I did not see any tests for this new functionality. I wrote a very simple
validation test for this new option here:
[`PutS3ObjectTest.groovy`](https://github.com/alopresto/nifi/blob/8abd3b8f7087fee1f6f7f97fe5867853cc346249/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/groovy/org.apache.nifi.processors.aws.s3/PutS3ObjectTest.groovy)
How much integration testing did you do for this feature?
> Modify PutS3Object to enable encryption
> ---------------------------------------
>
> Key: NIFI-1180
> URL: https://issues.apache.org/jira/browse/NIFI-1180
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Elli Schwarz
> Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the
> PutS3Object class, the objectMetadata object contains a method
> setSSEAlgorithm which can set encryption for the objects. A Nifi property
> should be added to the PutS3Object class so a user can enable/disable
> encryption from the processor itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
