[ 
https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170384#comment-15170384
 ] 

ASF GitHub Bot commented on NIFI-1180:
--------------------------------------

Github user adamonduty commented on the pull request:

    https://github.com/apache/nifi/pull/246#issuecomment-189581189
  
    @alopresto I looked up the inheritance chain and there aren't any other 
processors that follow the `name`/`displayName` convention. They all set `name` 
only. Is this convention documented somewhere? I couldn't find it in the 
developer guide, contributor guide, or mailing list...
    
    Also, doesn't changing the name attribute break backwards compatibility for 
existing attributes? The name field is used in `flow.xml.gz`, so changing it 
would cause a processor to "forget" the setting, unless I'm mistaken...
    
    I pushed another commit with integration tests for the server side 
encryption attribute.


> Modify PutS3Object to enable encryption
> ---------------------------------------
>
>                 Key: NIFI-1180
>                 URL: https://issues.apache.org/jira/browse/NIFI-1180
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Elli Schwarz
>            Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the 
> PutS3Object class, the objectMetadata object contains a method 
> setSSEAlgorithm which can set encryption for the objects. A Nifi property 
> should be added to the PutS3Object class so a user can enable/disable 
> encryption from the processor itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to