[
https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170372#comment-15170372
]
ASF GitHub Bot commented on NIFI-1180:
--------------------------------------
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/246#discussion_r54328675
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -177,10 +179,19 @@
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
.build();
+ public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new
PropertyDescriptor.Builder()
+ .name("Server Side Encryption")
--- End diff --
I totally understand consistency over convention. If I'm being selfish, I'd
say it is better to do it correctly *and* correct the other existing settings.
The preferred and prescribed form is to use `.name()` for the unique value. See
`EncryptContent` processor for a more complete example.
> Modify PutS3Object to enable encryption
> ---------------------------------------
>
> Key: NIFI-1180
> URL: https://issues.apache.org/jira/browse/NIFI-1180
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Elli Schwarz
> Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the
> PutS3Object class, the objectMetadata object contains a method
> setSSEAlgorithm which can set encryption for the objects. A Nifi property
> should be added to the PutS3Object class so a user can enable/disable
> encryption from the processor itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
