[
https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172383#comment-15172383
]
ASF GitHub Bot commented on NIFI-1180:
--------------------------------------
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/246#issuecomment-190332181
@adamonduty You are correct that the `.name`/`.displayName` convention is
not documented well. I pinged @joewitt to look for a canonical source for the
convention and we need to improve the documentation.
In this case, I am ok with not changing the existing `PropertyDescriptors`,
as it would break backwards compatibility as you noted. Unfortunately, this is
a side-effect of the attributes not being set "properly" in the first place --
the `displayName` value is visible to the end user through the UI and may need
to be changed, while the `name` value is used for object resolution in the
application and so should not need to change if the messaging changes (imagine
future internationalization where the `displayName` value is
language-dependent). However, I do think in this case, the new
`PropertyDescriptor` should follow the correct convention and a comment added
noting the reason for the difference with other `PropertyDescriptor`s in the
class.
> Modify PutS3Object to enable encryption
> ---------------------------------------
>
> Key: NIFI-1180
> URL: https://issues.apache.org/jira/browse/NIFI-1180
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Elli Schwarz
> Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the
> PutS3Object class, the objectMetadata object contains a method
> setSSEAlgorithm which can set encryption for the objects. A Nifi property
> should be added to the PutS3Object class so a user can enable/disable
> encryption from the processor itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
