xiaoxiang781216 commented on code in PR #12299: URL: https://github.com/apache/nuttx/pull/12299#discussion_r1593245173
########## include/nuttx/serial/tioctl.h: ########## @@ -198,6 +198,14 @@ #define SER_SWAP_ENABLED (1 << 0) /* Enable/disable RX/TX swap */ +/* Single-wire UART Duplex */ + +#define TIOCSSINGLEWIREDUPLEX _TIOC(0x0037) /* Set single-wire duplex mode */ +#define TIOCGSINGLEWIREDUPLEX _TIOC(0x0038) /* Get single-wire duplex mode */ Review Comment: why not continue use TIOCSSINGLEWIRE? ########## include/nuttx/serial/tioctl.h: ########## @@ -198,6 +198,14 @@ #define SER_SWAP_ENABLED (1 << 0) /* Enable/disable RX/TX swap */ +/* Single-wire UART Duplex */ + +#define TIOCSSINGLEWIREDUPLEX _TIOC(0x0037) /* Set single-wire duplex mode */ Review Comment: 0x48 dup with TIOCSLINID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
