davids5 commented on code in PR #12299:
URL: https://github.com/apache/nuttx/pull/12299#discussion_r1593515048
##########
arch/arm/src/imxrt/imxrt_serial.c:
##########
@@ -2629,7 +2629,7 @@ static int imxrt_ioctl(struct file *filep, int cmd,
unsigned long arg)
if ((arg & SER_SINGLEWIRE_ENABLED) != 0)
{
- uint32_t gpio_val = IOMUX_OPENDRAIN;
+ uint32_t gpio_val = 0;
Review Comment:
Maybe it is appropriate for the IMX, but we have seen multiple drivers on
the line and thresholding issues so the control was added for the PU control.
But in any case use IOMUX_PUSHPULL so there is not loss of information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
