davids5 commented on code in PR #12299:
URL: https://github.com/apache/nuttx/pull/12299#discussion_r1593491650
##########
arch/arm/src/imxrt/imxrt_serial.c:
##########
@@ -2629,7 +2629,7 @@ static int imxrt_ioctl(struct file *filep, int cmd,
unsigned long arg)
if ((arg & SER_SINGLEWIRE_ENABLED) != 0)
{
- uint32_t gpio_val = IOMUX_OPENDRAIN;
+ uint32_t gpio_val = 0;
Review Comment:
Why re-move the information?
##########
include/nuttx/serial/tioctl.h:
##########
@@ -202,6 +202,14 @@
#define TIOCSLINID _TIOC(0x0037) /* Master send one LIN header with
specified LIN identifier: uint8_t */
+/* Single-wire UART Duplex */
+
+#define TIOCSSINGLEWIREDUPLEX _TIOC(0x0038) /* Set single-wire duplex mode */
Review Comment:
I fund the name confusing, it is the opposite of what it is. It is SIMPLEX,
but, I would call it TIOCSSINGLEWIREUNIDIRECTIONAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
